Repository navigation
fix(critic): draw a comment as a note with a speech bubble, not an inline-code pill - #365
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
The visual change is sound, but the newly embedded third-party icon needs its redistribution notices included before release.
Reviewed changes Reviewed the CriticMarkup comment presentation and its documentation and test coverage.
- Comment styling Removes the bordered pill treatment and adds a current-color speech-bubble mask while preserving the existing tint, type size, spacing, and theme variables.
- Documentation Describes comments as muted notes, removes the obsolete
--comark-bordertoken use, and credits Lucide. - Regression coverage Verifies unchanged comment markup, absence of the edge, and presence of the mask; the focused 13-test suite and package build passed.
gpt-5.6-sol ｜ 𝕏
Latest result Pull request merged. Final answersSession Pull request merged. Session Pushed 8ae86ed resolving the merge conflict while preserving the completed clipboard-write wait. Critic tests passed 13/13; focused Playwright passed both clipboard cases. Scoped lint, formatting, typecheck, and git diff --check passed. Pullfrog’s prior license finding remains fixed; no actionable findings remain. Awaiting hosted checks and automated review. Session Pushed 8ae86ed resolving the merge conflict while preserving the completed clipboard-write wait. Critic tests passed 13/13; focused Playwright passed both clipboard cases. Scoped lint, formatting, typecheck, and git diff --check passed. Pullfrog’s prior license finding remains fixed; no actionable findings remain. Awaiting hosted checks and automated review. Session Pushed 8ae86ed resolving the merge conflict while preserving the completed clipboard-write wait. Critic tests passed 13/13; focused Playwright passed both clipboard cases. Scoped lint, formatting, typecheck, and git diff --check passed. Pullfrog’s prior license finding remains fixed; no actionable findings remain. Awaiting hosted checks and automated review. Session Pushed 8ae86ed resolving the merge conflict while preserving the completed clipboard-write wait. Critic tests passed 13/13; focused Playwright passed both clipboard cases. Scoped lint, formatting, typecheck, and git diff --check passed. Pullfrog’s prior license finding remains fixed; no actionable findings remain. Awaiting hosted checks and automated review. Session Pushed 8ae86ed resolving the merge conflict while preserving the completed clipboard-write wait. Critic tests passed 13/13; focused Playwright passed both clipboard cases. Scoped lint, formatting, typecheck, and git diff --check passed. Pullfrog’s prior license finding remains fixed; no actionable findings remain. Awaiting hosted checks and automated review. Session Pushed 8ae86ed resolving the merge conflict while preserving the completed clipboard-write wait. Critic tests passed 13/13; focused Playwright passed both clipboard cases. Scoped lint, formatting, typecheck, and git diff --check passed. Pullfrog’s prior license finding remains fixed; no actionable findings remain. Awaiting hosted checks and automated review. Session Pushed 8ae86ed resolving the merge conflict while preserving the completed clipboard-write wait. Critic tests passed 13/13; focused Playwright passed both clipboard cases. Scoped lint, formatting, typecheck, and git diff --check passed. Pullfrog’s prior license finding remains fixed; no actionable findings remain. Awaiting hosted checks and automated review. |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed the follow-up commit since the prior Pullfrog review.
- License notices Appended the Lucide ISC and applicable Feather MIT notices for the embedded
message-squareicon, resolving the prior release-blocking concern. - Clipboard E2E synchronization Replaced clipboard-type polling with a wait for the
Copiedstatus, which is emitted only afternavigator.clipboard.write()resolves, before decoding the PNG. - Verification All 13 focused Critic tests pass; the targeted annotate E2E could not launch locally because the runner lacks the Playwright Chromium binary.
gpt-5.6-sol ｜ 𝕏
comark-annotate
comark-badge
comark-cards
comark-carousel
comark-cast
comark-charts
comark-chat
comark-chips
comark-cjk
comark-code
comark-code-notes
comark-colors
comark-comments
comark-critic
comark-deflist
comark-details
comark-diagrams
comark-diff
comark-embed
comark-fields
comark-figure
comark-file-tree
comark-footnotes
comark-github
comark-icon
comark-include
comark-keys
comark-links
comark-linter
comark-magic-move
comark-mark
markdown-it-to-comark
marked-to-comark
comark-mathml
comark-media
comark-metrics
migrate-to-comark
comark-outline
comark-properties
comark-qr
comark-quiz
comark-reading-time
remark-to-comark
comark-sources
comark-steps
comark-table
comark-tabs
comark-tests
comark-time
comark-ui
comark-xref
comark-zoom
commit: |
A CriticMarkup comment, such as
{>>Pineapple still needs a vote.<<}, draws as a tinted pill with a hairline edge. That is how most docs themes draw inline code, so the note reads as code inside the sentence.This PR removes the edge and puts Lucide's speech bubble, in the comment's color, before the text. The tint, size, and margins stay the same. Comments no longer read
--comark-border, so the token table drops it.The docs app doesn't load these styles yet (#366 fixes that), so the before/after on Drop compares main's and this branch's css on the same
@comark/htmlrender, at 390px.The new test fails on main and passes here.
pnpm readypasses with all six demo fixes merged (133 test files, 2,748 tests, builds, typechecks, Doctor). I checked light mode at 390px and 1280px in Chromium, not dark mode or other browsers.