Repository navigation
fix(docs): list each package's category in its sidebar, ship the fonts, and style headings - #370
Merged
Merged
Conversation
Nitro 3 never calls rollup:before, where @nuxt/fonts 0.14 fills its font files, so every /_fonts file deployed empty since #369. Nuxt UI's dependency on it now resolves to 1.2, which downloads the fonts when Vite closes the bundle. comark-links draws the docs' headings, so Nuxt UI's ProseH2 never styles them and they rendered as 16px body text. The docs app now gives them ProseH2's sizes and spacing.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed the docs font-build dependency override and the top-level Markdown heading styling introduced in 7c5d882.
- Font emission — Overrides Nuxt UI's legacy
@nuxt/fontsdependency with the Nitro 3-compatible 1.2 release and updates the resolved font toolchain. - Page heading styles — Restores Nuxt UI-equivalent H2-H4 typography and spacing for both plain headings and comark-links anchor rows while excluding nested example content.
- Compatibility and verification — Confirmed the new dependency's Node and Nuxt integration constraints fit this repository, traced the rendered heading structure and selector scope, and reran
test/site.test.tssuccessfully.
gpt-5.6-sol ｜ 𝕏
comark-annotate
comark-badge
comark-cards
comark-carousel
comark-cast
comark-charts
comark-chat
comark-chips
comark-cjk
comark-code
comark-code-notes
comark-colors
comark-comments
comark-critic
comark-deflist
comark-details
comark-diagrams
comark-diff
comark-embed
comark-fields
comark-figure
comark-file-tree
comark-footnotes
comark-github
comark-icon
comark-include
comark-keys
comark-links
comark-linter
comark-magic-move
comark-mark
markdown-it-to-comark
marked-to-comark
comark-mathml
comark-media
comark-metrics
migrate-to-comark
comark-outline
comark-properties
comark-qr
comark-quiz
comark-reading-time
remark-to-comark
comark-sources
comark-steps
comark-table
comark-tabs
comark-tests
comark-time
comark-ui
comark-xref
comark-zoom
commit: |
Contributor
Latest result Pull request merged. Final answersSession Pull request merged. Ready: inspected the full diff and supplied feedback; no actionable findings remain and all current-head checks passed. Pullfrog found no issues; Codex review hit its usage limit. `node_modules/.bin/vp lint docs/app/components/DocsMarkdown.vue` passed. `node_modules/.bin/vp test test/site.test.ts` could not run because generated Nuxt tsconfigs are absent locally; hosted CI passed. No repair commit was needed; the working tree is clean. |
…tate's rail icon Every package page is a one-page section, so @vite-hub/docs showed a sidebar with a single link to the current page. A pnpm patch backports vite-hub/vitehub#3559, which lists the section's category instead. Lucide has no scribble-loop, so Annotate's rail item drew no icon. content.ts maps it to pen-tool, as the landing's package grid does.
onmax
changed the title
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed the sidebar grouping patch and Annotate navigation icon fix introduced in f4a1de3 since the prior Pullfrog review.
- Category sidebars — Added the upstream
docsSidebarGroup()behavior so one-page package sections list their category peers while multi-page sections continue to list their own pages. - Navigation icon — Mapped Annotate's landing-only
scribble-loopname to Lucide'spen-toolin generated docs navigation. - Patch lifecycle — Registered the ViteHub backport through pnpm and documented its upstream source and removal condition.
- Verification — Traced the grouping guard against the repository's generated section metadata and multi-page packages, and regenerated docs content to confirm the expected Diff category and Annotate icon output.
gpt-5.6-sol ｜ 𝕏
Closed
vite-hub Bot
added a commit
that referenced
this pull request
Nov 6, 2026
…nd code frames (#372) * fix(docs): one rail item per kind of page, as on the old site The rail had an item per package, and since #370 each package's sidebar lists its category's packages too, so every package showed twice. The rail now has Docs, Skills, Components, Typography, Linter, and Migrate, each a group whose sidebar lists its sections under their categories. Sections sort by category, so each heading shows once, and Mermaid joins Charts and diagrams instead of sitting alone in the rail. * fix(docs): bring back the old site's example tabs and code block frame Examples get the old underlined tabs, with the Preview/Code switch and the Playground link on the same row, and a block that draws its own frame, such as a diff, isn't framed again. Code blocks get their frame back: comark-code replaces pre, so Nuxt UI's prose styles never reached them and they had no padding or background. * fix(docs): avoid duplicate frames around annotate examples --------- Co-authored-by: vite-hub[bot] <320448255+vite-hub[bot]@users.noreply.github.com>
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On comark-ui.onmax.me, every package page's sidebar shows a single link to the page you're on, so
/diffreads as broken. Since #369 the fonts also ship as 0-byte files, and page headings render as 16px body text.Sidebar: each package is a section with one page, and
@vite-hub/docslists only the current section's pages. Apnpm patchbackports vite-hub/vitehub#3559, which lists the sections of the category instead, so/diffshows the 20 Review blocks with Diff active. Packages with several pages, like the linter, keep their own list.patches/README.mdsays when to drop the patch. While there, Annotate's rail item drew no icon, because Lucide has noscribble-loop.docs/content.tsnow maps it topen-tool, as the landing's package grid already does.Fonts: Nuxt UI 4.12 depends on
@nuxt/fonts0.14, which writes an empty placeholder for each font and fills it in Nitro'srollup:beforehook. Nitro 3 never runs that hook. This overrides Nuxt UI's dependency to@nuxt/fonts^1.2.0, which downloads the fonts when Vite closes the bundle.Headings: comark-links renders the docs'
h2toh4, so@comark/vuepicks itsH2over Nuxt UI'sProseH2.DocsMarkdown.vuenow gives them ProseH2's sizes and margins.I checked a local
pnpm docs:build. All 36 font files have bytes and everyurl()resolves. On/diff, Geist loads, "Features" is 24px/700, and the sidebar lists Review blocks, both on a direct load and after clicking from/code.vp checkon the changed files,test/site.test.ts, andpnpm install --frozen-lockfilepass. I didn't run the fullpnpm ready, and I haven't seen a deploy.