Repository navigation
Conversation
Signed-off-by: Yuhx141 <155034285+Yuhx141@users.noreply.github.com>
Member
|
Is this duplicate of #351 ? |
Contributor
Author
|
Yes, this duplicates #351. I’ll close it. Sorry for the duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ONNX Shape slices use clamped Python-style bounds. The shared optimizer helper only normalized negative indices, so out-of-range or reversed bounds could create invalid iterator ranges during elimination.
Clamp both bounds to the input rank and normalize end-before-start to an empty slice in FetchStartAndEndAttrOfShape. The shared fix also covers eliminate_shape_gather and eliminate_slice_after_shape.
This is the upstream counterpart requested in onnxsim/onnxsim#2015.
Test