WIP Add CurlHandle support#13
Closed
malberts wants to merge 1 commit intoonoi:masterfrom
malberts:curlhandle
Closed
WIP Add CurlHandle support#13malberts wants to merge 1 commit intoonoi:masterfrom malberts:curlhandle
malberts wants to merge 1 commit intoonoi:masterfrom
malberts:curlhandle
Conversation
Author
|
Superseded by #14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Semantic MediaWiki PHP 8 tests are failing because
resourcewas replaced byCurlHandle.SMW issue: SemanticMediaWiki/SemanticMediaWiki#5346
This is a hacky, partially tested fix. It makes the SMW CURL errors go away on PHP 8, though.
It's partially manually tested, because the unit tests are using ancient PHPUnit stuff which requires more fixes.
This could go into a release 1.4.0. The alternative proper solution is to start version 2.0.0 which supports only PHP 8.0+. SMW will then have to require either 2.x or 1.x.