Open
Conversation
|
https://github.com/sellerartifact/accesscontrol hi, We plan to maintain this repo and have merged this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OverView
This PR makes a lot of typing enhancements for TypeScript, with (basically) no functionaly changes.
This means we will get a partial of the data if the argument is an object, or an array of partials of the data if the argument is an array.
2. #90. This has not changed how to use the two enums but is really helpful for TypeScript.
3.
Actionenum now has value such ascreate:own. You cannot pretend that they are not part ofAction.4. Make
utilas class rather than a constant. This allows for method overloads.5. Move
lockfromutil.tstoAccessControl.ts._lockis private, thus it shouldn't be modified by other files.6. Update tsconfig and package-lock to be up-to-date.
Cover
Test Suites: 2 passed, 2 total
Tests: 51 passed, 51 total
Snapshots: 0 total
Time: 3.428s
Ran all test suites.
Mumbles
The last commit was 3 years ago. It’s a pity that such a good repository has been abandoned! I hope @onury may come back for code reviews. Anyone who is willing (or already has) to take over this repository are free to use my PR. :)