Open
Conversation
aagbsn
reviewed
Feb 10, 2026
| request: Request, | ||
| cc_reader: CCReaderDep, | ||
| asn_reader: ASNReaderDep, | ||
| clickhouse: Clickhouse |
Contributor
There was a problem hiding this comment.
aagbsn
reviewed
Feb 10, 2026
Contributor
aagbsn
left a comment
aagbsn
left a comment
There was a problem hiding this comment.
look good, small suggestion to reuse ClickhouseDep
| from .metrics import Metrics | ||
| from .common.config import Settings | ||
| from .common.clickhouse_utils import insert_click | ||
| from .dependencies import CCReaderDep, ASNReaderDep |
aagbsn
reviewed
Feb 10, 2026
| Metrics.SEND_FASTPATH_FAILURE.inc() | ||
|
|
||
| # wasn't possible to send msmnt to fastpath, try to send it to s3 | ||
| try: |
Contributor
There was a problem hiding this comment.
note: if submit to fastpath fails compare_probe_msmt_cc_asn doesn't get called
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the geoip mismatch heuristic for faulty measurement detection.
Closes: #1073
See: #1070