Open
Conversation
aagbsn
reviewed
Feb 10, 2026
Contributor
aagbsn
left a comment
aagbsn
left a comment
There was a problem hiding this comment.
this looks good, see comment
hellais
reviewed
Feb 11, 2026
hellais
reviewed
Feb 12, 2026
scripts/cluster-migration/schema.sql
Outdated
| -- faulty measurements | ||
| CREATE TABLE IF NOT EXISTS faulty_measurements ON CLUSTER oonidata_cluster | ||
| ( | ||
| `time` DateTime DEFAULT now(), |
Member
There was a problem hiding this comment.
For consistency with the other tables, I would suggest explicitly setting the timezone in here and avoiding defaulting to now(), so that no magic happens upon insert if the value is not present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the schema for the faulty measurements table
Closes #330