Open
Conversation
Zanderz/colors 2015.12.04
Taruti/update upstream+hilyjiang repo
Fixes this error when vendoring go/logger: github.com/keybase/client/go/logger/standard.go:208: log.internal.Criticalf undefined (type *logging.Logger has no field or method Criticalf)
Fixes missing Criticalf method
Revert "Fixes missing Criticalf method"
nim-nim
approved these changes
Oct 19, 2017
nim-nim
left a comment
nim-nim
left a comment
There was a problem hiding this comment.
Needed for github.com/hudl/fargo too
Contributor
Author
|
Someone else will need to merge, I lack permission |
Cleanup library, add RW locks
Migrate to Go Modules
test against supported go versions
test against the latest versions of go
migrate to github actions
Test against the latest versions of Go
Upgrade to go 1.23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves several things back to a shared log.go. We have started supporting ansi color control codes on Windows by (using an io.writer that looks for them)[https://github.com/keybase/client/blob/master/go/libkb/output_windows.go]. That could also be brought over to op/go-logging if anyone wants.
This is merged on top of your recent Windows fix - thanks again.