Skip to content

feat(winget): configure release asset markers - #39

Merged
rianjs merged 1 commit into
mainfrom
issue-38-winget-assets
Aug 11, 2026
Merged

feat(winget): configure release asset markers#39
rianjs merged 1 commit into
mainfrom
issue-38-winget-assets

Conversation

@rianjs

@rianjs rianjs commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Closes #38.

What changed

  • added optional x64 and ARM64 release-asset markers to the shared Winget action
  • preserved the existing Go CLI ZIP markers as defaults
  • failed closed when markers are empty, equal, ambiguous, or match multiple assets
  • covered configured Retune NSIS assets plus action and CLI wiring

Why

Retune publishes architecture-specific NSIS installers whose names differ from the existing Go CLI ZIP convention. Keeping marker selection at the shared action boundary lets Retune use the same bootstrap/update path without changing current consumers.

Validation

  • uv run --with 'pytest>=8,<9' --with 'PyYAML==6.0.2' pytest -q -p no:cacheprovider (31 passed)
  • full neighboring Python action suites (100 passed)
  • repository shell gates, YAML parsing, and diff checks

Parent workstream: open-cli-collective/Retune#2

@rianjs-bot rianjs-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated PR Review

Reviewed commit: ba3545bab31f
Profile: codex-rianjs-bot - Posting as: rianjs-bot[bot]

Summary

Reviewer Findings
automation:ci-release 0
policies:conventions 0

Reviewer Coverage

  • automation:ci-release — complete (broad); skipped: none; constraints: Focused on the assigned Winget action and its supporting Python/tests. The targeted pytest command could not run because this environment cannot resolve PyPI.
  • policies:conventions — complete (broad); inspected 2 assigned files (3 inspected across reviewers): actions/winget-submit/action.yml, actions/winget-submit/winget_submit.py; skipped: none; constraints: Shared cli-common policy documents were not present in the review workspace; review used the repository README and assigned diff.
Inspected files (3)
  • actions/winget-submit/action.yml
  • actions/winget-submit/test_winget_submit.py
  • actions/winget-submit/winget_submit.py

0 PR discussion threads considered. 0 summarized; 0 resolved.


Completed in 1m 21s | gpt-5.6-terra | cr 0.10.284
Field Value
Model gpt-5.6-terra
Reviewers automation:ci-release, policies:conventions
Engine codex_cli · gpt-5.6-terra
Reviewed by cr · rianjs-bot[bot]
Duration 1m 21s wall · 2m 08s compute
Cost unavailable
Tokens 303.0k in / 3.6k out

Per-workstream usage

  • orchestrator-selection — gpt-5.6-terra
    • In: 16.6k
    • Out: 220
    • Cache read: 11.0k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 7s
  • automation:ci-release — gpt-5.6-terra
    • In: 124.3k
    • Out: 1.7k
    • Cache read: 93.2k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 50s
  • policies:conventions — gpt-5.6-terra
    • In: 127.5k
    • Out: 1.5k
    • Cache read: 103.2k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 1m 03s
  • orchestrator-rollup — gpt-5.6-terra
    • In: 34.6k
    • Out: 256
    • Cache read: 22.0k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 5s

@rianjs
rianjs marked this pull request as ready for review August 11, 2026 14:26
@rianjs
rianjs merged commit 74d24fc into main Aug 11, 2026
20 checks passed
@rianjs
rianjs deleted the issue-38-winget-assets branch August 11, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Winget action: support configurable x64/arm64 release-asset markers for Retune

1 participant