test(jtk): INT-693 pin priority keeping the literal name None - #472
Merged
Conversation
Jira ships a built-in Priority literally named None in many instances, so --field priority=None hitting the name-addressed branch is a real scenario, and it is exactly the case the clearing contract calls out: name-addressed types keep None as a value; only the empty value clears. [INT-693]
monit-reviewer
approved these changes
Aug 7, 2026
monit-reviewer
left a comment
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: d4918e24ddc5
Profile: claude-monit-reviewer - Posting as: monit-reviewer
Summary
| Reviewer | Findings |
|---|---|
| go:implementation-tests | 0 |
| policies:conventions | 0 |
Reviewer Coverage
go:implementation-tests— complete (broad); skipped: none; constraints: nonepolicies:conventions— complete (broad); skipped: none; constraints: none
Inspected files (1)
tools/jtk/api/fields_test.go
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 1m 15s | ~$1.46 (est.) | claude-sonnet-5 | cr 0.10.282
| Field | Value |
|---|---|
| Model | claude-sonnet-5 |
| Reviewers | go:implementation-tests, policies:conventions |
| Engine | claude_cli · claude-sonnet-5 |
| Reviewed by | cr · monit-reviewer |
| Duration | 1m 15s wall · 1m 23s compute |
| Cost | ~$1.46 (est.) |
| Tokens | 30 in / 4.1k out |
Per-workstream usage
orchestrator-selection— claude-sonnet-5- In: 4
- Out: 860
- Cache read: 31.2k
- Cache create: 73.1k
- Cost: ~$0.30 (est.)
- Duration: 15s
go:implementation-tests— claude-sonnet-5- In: 8
- Out: 957
- Cache read: 186.1k
- Cache create: 84.6k
- Cost: ~$0.39 (est.)
- Duration: 20s
policies:conventions— claude-sonnet-5- In: 12
- Out: 1.9k
- Cache read: 315.8k
- Cache create: 77.8k
- Cost: ~$0.41 (est.)
- Duration: 35s
orchestrator-rollup— claude-sonnet-5- In: 6
- Out: 413
- Cache read: 100.1k
- Cache create: 86.7k
- Cost: ~$0.36 (est.)
- Duration: 11s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[INT-693]
Fast-follow to #471, addressing its review finding: the name-addressed branch (priority/resolution/status/issuetype/securitylevel) shares the only-empty-clears contract but had no literal-
Nonecase — and Jira ships a built-in Priority literally named "None" in many instances, so--field priority=Nonehitting that path is a real scenario.One test-table case:
priority=None→{"name": "None"}, mirroring the existing option-field case. GitHub-signed commit (themainruleset requires verified signatures).