Repository navigation
test: pin the golden-layout test to POSIX within the 300-line budget (IR-27b) - #334
Merged
Merged
Conversation
…ne budget (IR-27b) The golden file is the POSIX form on every platform, including under CHOCK_REGEN_GOLDENS=1. The pin (hook_dir.build_windows -> False) and the compare live in packaging_helpers.golden_posix, so tests/test_plugin_install_targets.py stays under 300 lines. Supersedes #333. Signed-off-by: Jothi Mani Rajendran <250249270+jothimani-rajendran@users.noreply.github.com>
jothimani-rajendran
marked this pull request as ready for review
October 26, 2026 03:59
The base ruleset requires the head to be up to date before a merge. Signed-off-by: Jothi Mani Rajendran <250249270+jothimani-rajendran@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Lands the chock#333 pin (
hook_dir.build_windows-> False in the golden-layout test, regen path included) withtests/test_plugin_install_targets.pyat 299 lines (budget 300).How
The pin and the golden compare move into
golden_posixintests/packaging_helpers.py; the test is one call. No golden file changes; no other test touched.Checks
pytest tests/test_repo_standards.py tests/test_plugin_install_targets.py: 44 passedruff check tests/andruff format --checkon both files: cleanSupersedes #333.