[Fix] MM-IFEval: import rule-based verify functions into module globals - #1601
Open
cdpark92 wants to merge 1 commit into
Open
[Fix] MM-IFEval: import rule-based verify functions into module globals#1601cdpark92 wants to merge 1 commit into
cdpark92 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
vlmeval/dataset/mmifeval.pydispatches rule-based constraint verifiers by name:The verify functions (
check_whether_response_word_count_in_range,check_whether_response_paragraph_number_in_range, ...) are defined invlmeval/dataset/utils/mmif/function_and_compare.pybut are never imported intommifeval's module namespace, so theglobals()lookup raisesKeyError: 'check_whether_response_word_count_in_range'for every item thatcontains a rule-based constraint. The lookup is outside the surrounding
try/exceptblocks (those only wrap the GPT-judged branches), so MM-IFEvalevaluation cannot complete on any prediction set that includes rule-based
constraints.
Fix
Import the verify functions into the module globals (+5 lines including the
explanatory comment):
Verification
KeyErrorabove on the firstrule-based item.
(word-count ranges, paragraph counts, punctuation rules, ...) score correctly.
Verified end-to-end on local runs with sub-1B open VLMs (e.g.
LiquidAI/LFM2.5-VL-450M).