Skip to content

chore: Update docker image to have Go 1.25 and Node 22#97

Open
jsteinich wants to merge 1 commit intoopen-constructs:mainfrom
jsteinich:docker_jsii_5-9
Open

chore: Update docker image to have Go 1.25 and Node 22#97
jsteinich wants to merge 1 commit intoopen-constructs:mainfrom
jsteinich:docker_jsii_5-9

Conversation

@jsteinich
Copy link
Copy Markdown
Collaborator

Description

Updating to JSII 5.9 requires go 1.25. The updated jsii superchain image contains that version.
Also updating to use node 22 as node 20 will become EoL in a couple weeks.

We'll then need a subsequent PR to actually use the new image before then making PRs to actually update JSII/Node.

Checklist

  • I have updated the PR title to match CDKTN's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

vincenthsh

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor

@so0k so0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - note that I sha pinned the jsii-terraform container

image: terraconstructs/jsii-terraform@sha256:4942a4c6ed8286f403c7855dab56b0e11f9a7115e7e0afbcd49d7e69de4d6dc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants