refactor: Units inherit Containers (Multi-Table Inheritance)#17
Merged
bradenmacdonald merged 7 commits intobraden/containers-unitsfrom Mar 12, 2025
Merged
refactor: Units inherit Containers (Multi-Table Inheritance)#17bradenmacdonald merged 7 commits intobraden/containers-unitsfrom
bradenmacdonald merged 7 commits intobraden/containers-unitsfrom
Conversation
bradenmacdonald
commented
Mar 11, 2025
a3d10bd to
13004f9
Compare
c345f1b to
6061984
Compare
6061984 to
fca9b3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies openedx#278 to use multi-table inheritance, so Units are a subclass of Containers.
Features:
Unitin pythonisinstanceofContainer✅UnitVersionin pythonisinstanceofContainerVersion✅Unit.versioning.draftwill give you aUnitVersion, andContainer.versioning.draftwill give you aContainerVersion✅PublishableEntityVersion(onContainerVersion, not onUnitVersion) ✅UnitandUnitVersionhave their own database tables and can be the source/target for unit-specific foreign keys ✅UnitandUnitVersionare now so simple that we don't need aContainerMixinnorContainerVersionMixinat all ✅