g3d: Implement ResMaterial and ResShaderParam - #88
Closed
arayaphong wants to merge 1 commit into
Closed
arayaphong wants to merge 1 commit into
arayaphong wants to merge 1 commit into
Conversation
Member
|
Please file this PR against https://github.com/open-ead/nnware instead - we are planning to migrate from this repo to that one over the next weeks/months. No changes are accepted on this repo anymore. Port your changes over, then simply close this one. |
arayaphong
force-pushed
the
implement/g3d-res-material
branch
from
September 25, 2026 11:28
3aa2f46 to
b2fdfd2
Compare
Author
|
Closing as requested - porting this to open-ead/nnware instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
nn::g3d::ResMaterialandnn::g3d::ResShaderParam(NintendoWare/g3d/ResMaterial.cpp) for OdysseyDecomp, tracked in MonsterDruide1/OdysseyDecompTracker#3736.ResMaterial.omatch.ResShaderParam::ConvertSrt3dCallbackis non-matching (SIMD scheduling and register allocation), markedNON_MATCHINGwith a decomp.me link: https://decomp.me/scratch/lkHXpnn/g3d/ResMaterial.h,nn/gfx/gfx_Sampler.handnn/util/util_Arithmetic.h, and adds the source toCMakeLists.txt.I suspect the original had a different code structure, probably Nintendo's nn::util inline helpers, and just reordering lines won't reach 100%.
Formatted with clang-format 14 (as used by this repo's lint workflow).
This change is