Open
Conversation
guptadevagya
commented
Sep 29, 2025
go/worker/cgroup_rootless.go
Outdated
Contributor
Author
There was a problem hiding this comment.
rootless helpers: find user.slice, pick a cgroup pool path, and enable controllers best-effort
fixed clean up code, graceful fallback in case of no cgroup delegation
Contributor
|
One thing that I noticed while testing is that cgroup delegation under user slices in systemd, is not something that's enabled on all systems. In my case (Arch Linux), it was off by default. When that happens, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a rootless mode for the worker (in --detach). we start the worker in a user namespace (fake root) and move the cgroup pool under the systemd user slice. if controllers aren’t delegated, we skip cgroup writes instead of crashing. includes small preflight hints and a retry if a cg-* dir already exists.