Skip to content

Fixed context center flaky test - #31570

Open
Rohit0301 wants to merge 4 commits into
mainfrom
context-center-flaky
Open

Fixed context center flaky test#31570
Rohit0301 wants to merge 4 commits into
mainfrom
context-center-flaky

Conversation

@Rohit0301

@Rohit0301 Rohit0301 commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Describe your changes:

Fixes #

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Summary by Gitar

  • Test improvements:
    • Replaced fixed timeouts with robust polling and network response waits in Playwright tests
    • Added waitForDraftPersisted helper to eliminate draft persistence races under CI load

This will update automatically on new commits.

@Rohit0301 Rohit0301 self-assigned this Aug 15, 2026
@Rohit0301 Rohit0301 added the safe to test Add this label to run secure Github workflows on PRs label Aug 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added the UI UI specific issues label Aug 15, 2026
@Rohit0301 Rohit0301 added safe to test Add this label to run secure Github workflows on PRs and removed safe to test Add this label to run secure Github workflows on PRs labels Aug 15, 2026
@github-actions

github-actions Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 4a7e6706ccfb9305563afdb3af06795847238870 in Playwright run 31883622514, attempt 1.

✅ 680 passed · ❌ 0 failed · 🟡 2 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 26m 29s

⏱️ Max setup 3m 5s · max shard execution 16m 58s · max shard-job elapsed before upload 20m 28s · reporting 5s

🌐 199.81 requests/attempt · 2.66 app boots/UI scenario · 15.32% common-shard skew

Optimization targets still in progress:

  • Common shard skew was 15.32% (convergence target: at most 15%).
  • Application boot ratio was 2.66 per UI scenario (1937 boots / 729 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 113 0 0 0 0 0
🟡 Shard chromium-02 141 0 1 0 0 0
✅ Shard chromium-03 113 0 0 0 0 0
✅ Shard chromium-04 155 0 0 0 0 0
✅ Shard data-asset-rules-01 61 0 0 0 0 0
✅ Shard domain-isolation-01 14 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
🟡 Shard ingestion-01 8 0 1 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 10 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0
🟡 2 flaky test(s) (passed on retry)
  • Features/ContextCenterArticles.spec.tsText formatting (shard chromium-02, 1 retry)
  • Flow/ServiceCreationPermissions.spec.tsUser with EditAll but not Trigger cannot run a pipeline (shard ingestion-01, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@gitar-bot

gitar-bot Bot commented Aug 15, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Replaces fixed timeouts with robust polling and adds the waitForDraftPersisted helper in Playwright tests to eliminate context center test flakiness under CI load. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant