Skip to content

Add explicit rmf_traffic dependencies #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxgrey merged 1 commit into from
Sep 7, 2026
Merged

Add explicit rmf_traffic dependencies #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rmf_task/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ add_library(rmf_task SHARED
target_link_libraries(rmf_task
PUBLIC
rmf_battery::rmf_battery
rmf_traffic::rmf_traffic
nlohmann_json::nlohmann_json
Threads::Threads
$<$<CXX_COMPILER_ID:GNU>:stdc++fs>
Expand Down
1 change: 1 addition & 0 deletions rmf_task/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

<depend>rmf_battery</depend>
<depend>rmf_utils</depend>
<depend>rmf_traffic</depend>
<depend>nlohmann-json-dev</depend>

<depend>eigen</depend>
Expand Down
2 changes: 2 additions & 0 deletions rmf_task_sequence/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ include(GNUInstallDirs)

find_package(rmf_api_msgs REQUIRED)
find_package(rmf_task REQUIRED)
find_package(rmf_traffic REQUIRED)
find_package(nlohmann_json REQUIRED)
find_package(nlohmann_json_schema_validator_vendor REQUIRED)
find_package(nlohmann_json_schema_validator REQUIRED)
Expand All @@ -41,6 +42,7 @@ add_library(rmf_task_sequence SHARED
target_link_libraries(rmf_task_sequence
PUBLIC
rmf_task::rmf_task
rmf_traffic::rmf_traffic

@luca-della-vedova luca-della-vedova Jul 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that rmf_task is missing this dependency in its library, should it be added there as well?

@Plumezz Plumezz Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, yes, I agree. I think it should be added as well.

I will update the PR.

nlohmann_json::nlohmann_json
nlohmann_json_schema_validator::validator
)
Expand Down
1 change: 1 addition & 0 deletions rmf_task_sequence/cmake/rmf_task_sequence-config.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ get_filename_component(rmf_task_sequence_CMAKE_DIR "${CMAKE_CURRENT_LIST_FILE}"
include(CMakeFindDependencyMacro)

find_dependency(rmf_task)
find_dependency(rmf_traffic)
find_dependency(nlohmann_json)
find_dependency(nlohmann_json_schema_validator_vendor)
find_dependency(nlohmann_json_schema_validator)
Expand Down
1 change: 1 addition & 0 deletions rmf_task_sequence/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

<depend>rmf_api_msgs</depend>
<depend>rmf_task</depend>
<depend>rmf_traffic</depend>
<depend>nlohmann-json-dev</depend>
<depend>nlohmann_json_schema_validator_vendor</depend>

Expand Down
Loading