Skip to content

Remove prometheus default host log warning #8679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jack-berg wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −7
Open

Remove prometheus default host log warning #8679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions ...theus/src/main/java/io/opentelemetry/exporter/prometheus/PrometheusHttpServerBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.function.Predicate;
import java.util.logging.Logger;
import javax.annotation.Nullable;

/** A builder for {@link PrometheusHttpServer}. */
Expand All @@ -27,8 +26,6 @@ public final class PrometheusHttpServerBuilder {
static final int DEFAULT_PORT = 9464;
private static final String DEFAULT_HOST = "localhost";
private static final MemoryMode DEFAULT_MEMORY_MODE = MemoryMode.REUSABLE_DATA;
private static final Logger LOGGER =
Logger.getLogger(PrometheusHttpServerBuilder.class.getName());

// Temporarily nullable to detect when it's not set and log warning about 0.0.0.0 -> localhost
// change
Expand Down Expand Up @@ -200,10 +197,6 @@ public PrometheusHttpServer build() {
}
String resolvedHost = host;
if (resolvedHost == null) {
// TODO (jack-berg): Remove log after 1.64.0 release
LOGGER.info(
"PrometheusHttpServer host not set, defaulting to localhost. Previously defaulted to 0.0.0.0. "
+ "If you depend on the old behavior, set host to 0.0.0.0 explicitly.");
resolvedHost = DEFAULT_HOST;
}
return new PrometheusHttpServer(
Expand Down
Loading