fix(sqlalchemy): avoid IndexError in _operation_name for comment/whitespace-only statements - #4943
Open
Atishyy27 wants to merge 2 commits into
Open
Conversation
…espace-only statements A statement that is truthy but has no tokens after leading-comment or whitespace stripping made .split()[0] raise IndexError in _operation_name. Guard it so such a statement falls back to the db name / vendor instead of crashing. Adds a regression test. Follow-up to open-telemetry#4934. Signed-off-by: Atishyy27 <142108881+Atishyy27@users.noreply.github.com>
Signed-off-by: Atishyy27 <142108881+Atishyy27@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same class as #4934, in the SQLAlchemy instrumentation's
_operation_name: a comment-only / whitespace-only statement is truthy but has no tokens after leading-comment stripping, so.split()[0]raisesIndexError. Guards it so such a statement falls back to the db name / vendor instead of crashing.Type of change: Bug fix (non-breaking)
How Has This Been Tested? Added
test_operation_name_comment_or_whitespace_only(unit test on_operation_name); existing tests still pass. Verified locally.Does This PR Require a Core Repo Change? No.