Skip to content

Add review instructions for build infra and root config - #385

Merged
lmolkova merged 4 commits into
open-telemetry:mainfrom
lmolkova:add-build-config-review-instructions
Aug 14, 2026
Merged

Add review instructions for build infra and root config#385
lmolkova merged 4 commits into
open-telemetry:mainfrom
lmolkova:add-build-config-review-instructions

Conversation

@lmolkova

Copy link
Copy Markdown
Member

We had no Copilot review instructions for build infrastructure and root-level config, so PRs touching them were reviewed against no repo rules; this adds a repo-wide copilot-instructions.md and an applyTo file covering tox.ini, pytest.ini, root pyproject.toml, and scripts/.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Aug 14, 2026

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-08-14 20:59 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@lmolkova lmolkova added the Skip Changelog PR does not require a changelog entry label Aug 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds repository-wide GitHub Copilot review guidance for changes that touch build/test/CI infrastructure and root-level configuration, aiming to ensure reviews catch issues CI can’t detect (e.g., silently reduced coverage or incomplete tox wiring).

Changes:

  • Adds a build/config-focused instruction file scoped to root config, scripts/, and CI workflows.
  • Adds repo-wide “what not to flag” guidance to avoid duplicating deterministic CI gate findings.
  • Documents root-config shadowing behavior (e.g., per-package pyproject.toml overriding root pytest.ini).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/instructions/build-config.instructions.md New scoped review rules for build/test matrix/CI config changes.
.github/copilot-instructions.md New repo-wide baseline rules (including CI-gate “don’t duplicate” guidance and root-config shadowing notes).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/instructions/build-config.instructions.md
Comment thread .github/copilot-instructions.md
@lmolkova
lmolkova added this pull request to the merge queue Aug 14, 2026
Merged via the queue into open-telemetry:main with commit ae03431 Aug 14, 2026
105 checks passed
@lmolkova
lmolkova deleted the add-build-config-review-instructions branch August 14, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PR does not require a changelog entry

Development

Successfully merging this pull request may close these issues.

3 participants