Add review instructions for build infra and root config - #385
Merged
lmolkova merged 4 commits intoAug 14, 2026
Merged
Conversation
Pull request dashboard statusMerged · refreshed 2026-08-14 20:59 UTC Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds repository-wide GitHub Copilot review guidance for changes that touch build/test/CI infrastructure and root-level configuration, aiming to ensure reviews catch issues CI can’t detect (e.g., silently reduced coverage or incomplete tox wiring).
Changes:
- Adds a build/config-focused instruction file scoped to root config,
scripts/, and CI workflows. - Adds repo-wide “what not to flag” guidance to avoid duplicating deterministic CI gate findings.
- Documents root-config shadowing behavior (e.g., per-package
pyproject.tomloverriding rootpytest.ini).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/instructions/build-config.instructions.md |
New scoped review rules for build/test matrix/CI config changes. |
.github/copilot-instructions.md |
New repo-wide baseline rules (including CI-gate “don’t duplicate” guidance and root-config shadowing notes). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
eternalcuriouslearner
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had no Copilot review instructions for build infrastructure and root-level config, so PRs touching them were reviewed against no repo rules; this adds a repo-wide
copilot-instructions.mdand anapplyTofile coveringtox.ini,pytest.ini, rootpyproject.toml, andscripts/.