opentelemetry-api: remove unnecessary copy in iterator#5288
Merged
lzchen merged 3 commits intoJun 11, 2026
Conversation
MikeGoldsmith
approved these changes
Jun 11, 2026
MikeGoldsmith
left a comment
MikeGoldsmith
left a comment
Member
There was a problem hiding this comment.
There's a lint error on the new benchmark test, but this looks awesome. Thanks @codeboten 🚀
Contributor
Author
|
Yah, was waiting on the other pr i opened before rebasing. Thanks for the review! |
The list of keys should be all that's needed for the iterator Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
force-pushed
the
codeboten/remove-dict-copy
branch
from
2747a83 to
afeb819
Compare
Contributor
Author
|
The failure appears unrelated to this change |
lzchen
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The list of keys should be all that's needed for the iterator on a Mapping. Will rebase after #5287
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran benchmarks and got the following comparison:
Does This PR Require a Contrib Repo Change?
Checklist: