Repository navigation
Conversation
…s after the declarative config is setup
Pull request dashboard statusWaiting on the author · refreshed 2026-10-13 00:13 UTC Respond to 2 review items (e.g. link a commit, explain why not, ask a follow-up): Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new logging path does not preserve its handler across subsequent logging reconfiguration, and the documented configurator precedence is inaccurate.
2 open findings
What changed in this PR
Adds support for Python-specific environment extensions alongside declarative SDK configuration.
Changes:
- Applies logging and provider configurator extensions after loading configuration files.
- Adds routing and provider behavior tests.
- Updates documentation and changelog.
| File | Description |
|---|---|
.changelog/5699.added |
Records the new extension support. |
docs/sdk/configuration.rst |
Documents declarative configuration behavior. |
opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py |
Applies Python extensions after declarative setup. |
opentelemetry-sdk/src/opentelemetry/sdk/environment_variables/__init__.py |
Updates environment-variable documentation. |
opentelemetry-sdk/tests/_configuration/test_configurator_file_routing.py |
Tests declarative routing and ordering. |
opentelemetry-sdk/tests/test_configurator.py |
Tests configurator application conditions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+615
to
+618
| if setup_logging_handler: | ||
| logger_provider = get_logger_provider() | ||
| handler = LoggingHandler(level=logging.NOTSET, logger_provider=logger_provider) | ||
| logging.getLogger().addHandler(handler) |
Comment on lines
+150
to
+151
| tracer, meter, and logger configurators replace the corresponding | ||
| provider's default configurator when that provider section is present. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, when
OTEL_CONFIG_FILEwas set, everyOTEL_PYTHON*implementation extension (e.g.OTEL_PYTHON_LOGGING_AUTO_INSTRUMENTATION_ENABLED,OTEL_PYTHON_TRACER_CONFIGURATOR) was silently bypassed. This PR adds functionality to honour these extensions as environment variables even when the declarative configuration is set.Fixes #5352
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
All existing tests pass. Added the following new tests:
test_python_extensions_run_after_declarative_configurationtest_python_configurators_are_applied_to_configured_global_providerstest_python_configurators_are_not_applied_when_provider_sections_are_omittedtest_python_configurators_are_not_applied_when_config_is_disabledDoes This PR Require a Contrib Repo Change?
Checklist: