Skip to content

Added Tests for default values being null - #5767

Open
SaisakthiM wants to merge 1 commit into
open-telemetry:mainfrom
SaisakthiM:main
Open

SaisakthiM wants to merge 1 commit into
open-telemetry:mainfrom
SaisakthiM:main

Conversation

@SaisakthiM

@SaisakthiM SaisakthiM commented Oct 11, 2026 •

Copy link
Copy Markdown

Description

This PR adds a test for default values being out of range and being null as a regression test

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Test
❯ pytest codegen/opentelemetry-codegen-json/tests/test_default_values.py -v
=============================================================================== test session starts ================================================================================
platform linux -- Python 3.14.7, pytest-9.0.3, pluggy-1.6.0 -- /home/saisakthi/Coding-Project/General Programming Skills/Git/opentelemetry-python/.venv/bin/python
cachedir: .pytest_cache
rootdir: /home/saisakthi/Coding-Project/General Programming Skills/Git/opentelemetry-python
configfile: pyproject.toml
plugins: platformdirs-4.13.0
collected 31 items                                                                                                                                                                 

codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_get_default_value_known_types[1-0.0] PASSED                                                            [  3%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_get_default_value_known_types[2-0.0] PASSED                                                            [  6%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_get_default_value_known_types[3-0] PASSED                                                              [  9%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_get_default_value_known_types[13-0] PASSED                                                             [ 12%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_get_default_value_known_types[18-0] PASSED                                                             [ 16%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_get_default_value_known_types[8-False] PASSED                                                          [ 19%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_get_default_value_known_types[9-""] PASSED                                                             [ 22%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_get_default_value_known_types[12-b""] PASSED                                                           [ 25%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_get_default_value_valid_types_without_default[10] PASSED                                               [ 29%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_get_default_value_valid_types_without_default[11] PASSED                                               [ 32%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_get_default_value_valid_types_without_default[14] PASSED                                               [ 35%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_get_default_value_out_of_range[0] PASSED                                                               [ 38%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_get_default_value_out_of_range[-1] PASSED                                                              [ 41%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_get_default_value_out_of_range[999] PASSED                                                             [ 45%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_get_default_value_out_of_range[2147483648] PASSED                                                      [ 48%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_every_mapped_type_has_a_default PASSED                                                                 [ 51%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_default_is_valid_python_literal[1] PASSED                                                              [ 54%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_default_is_valid_python_literal[2] PASSED                                                              [ 58%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_default_is_valid_python_literal[3] PASSED                                                              [ 61%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_default_is_valid_python_literal[4] PASSED                                                              [ 64%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_default_is_valid_python_literal[5] PASSED                                                              [ 67%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_default_is_valid_python_literal[6] PASSED                                                              [ 70%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_default_is_valid_python_literal[7] PASSED                                                              [ 74%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_default_is_valid_python_literal[8] PASSED                                                              [ 77%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_default_is_valid_python_literal[9] PASSED                                                              [ 80%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_default_is_valid_python_literal[12] PASSED                                                             [ 83%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_default_is_valid_python_literal[13] PASSED                                                             [ 87%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_default_is_valid_python_literal[15] PASSED                                                             [ 90%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_default_is_valid_python_literal[16] PASSED                                                             [ 93%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_default_is_valid_python_literal[17] PASSED                                                             [ 96%]
codegen/opentelemetry-codegen-json/tests/test_default_values.py::test_default_is_valid_python_literal[18] PASSED                                                             [100%]

================================================================================ 31 passed in 0.45s ================================================================================

Issue and Doubt

Is the get_default_value intentionally defaulted to None, if that's not the case we can raise a Index or a ValueError and change the test
I wanted to raise a issue but i just asked it here

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • [ ] Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@SaisakthiM
SaisakthiM requested a review from a team as a code owner October 11, 2026 04:29
@linux-foundation-easycla

linux-foundation-easycla Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: SaisakthiM / name: SaisakthiM (4b73f19)

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Waiting on reviewers · refreshed 2026-10-11 04:48 UTC

Review the latest changes.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant