Skip to content

[Fix #1612] Adding test with fixed collection #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjtirado merged 2 commits into from
Aug 31, 2026
Merged

[Fix #1612] Adding test with fixed collection #1614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc5dd62
[Fix #1612] Adding test with fixed collection
fjtirado Aug 11, 2026
688270b
[Fix #1612] Update example after schema fix
fjtirado Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fluent/spec/src/main/java/io/serverlessworkflow/fluent/spec/ForEachTaskBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
*/
package io.serverlessworkflow.fluent.spec;

import io.serverlessworkflow.api.types.ForIn;
import io.serverlessworkflow.api.types.ForTask;
import io.serverlessworkflow.api.types.ForTaskConfiguration;
import io.serverlessworkflow.api.types.In;
import io.serverlessworkflow.api.types.TaskItem;
import io.serverlessworkflow.fluent.spec.spi.ForEachTaskFluent;
import java.util.List;
Expand Down Expand Up @@ -49,7 +49,7 @@ public ForEachTaskBuilder<T> each(String each) {
}

public ForEachTaskBuilder<T> in(String in) {
this.forTaskConfiguration.setIn(new In().withForInExpression(in));
this.forTaskConfiguration.setIn(new ForIn().withForInExpression(in));
return this;
}

Expand Down
4 changes: 2 additions & 2 deletions impl/core/src/main/java/io/serverlessworkflow/impl/executors/ForExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
*/
package io.serverlessworkflow.impl.executors;

import io.serverlessworkflow.api.types.ForIn;
import io.serverlessworkflow.api.types.ForTask;
import io.serverlessworkflow.api.types.In;
import io.serverlessworkflow.impl.TaskContext;
import io.serverlessworkflow.impl.WorkflowContext;
import io.serverlessworkflow.impl.WorkflowDefinition;
Expand Down Expand Up @@ -51,7 +51,7 @@ protected Optional<WorkflowPredicate> buildWhileFilter() {
}

protected WorkflowValueResolver<Collection<?>> buildCollectionFilter() {
In in = task.getFor().getIn();
ForIn in = task.getFor().getIn();
return application
.expressionFactory()
.resolveCollection(
Expand Down
5 changes: 5 additions & 0 deletions impl/test/src/test/java/io/serverlessworkflow/impl/test/WorkflowDefinitionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,11 @@ private static Stream<Arguments> provideParameters() {
Map.of("input", Arrays.asList(1, 2, 3)),
o -> assertThat(o).isEqualTo(6),
c -> assertThat(c).isEqualTo(Map.of("incr", Arrays.asList(2, 3, 4)))),
args(
"workflows-samples/for-sum-fixed.yaml",
Map.of(),
o -> assertThat(o).isEqualTo(6),
c -> assertThat(c).isEqualTo(Map.of("incr", Arrays.asList(2, 3, 4)))),
args(
"workflows-samples/switch-then-loop.yaml",
Map.of("count", 1),
Expand Down
22 changes: 22 additions & 0 deletions impl/test/src/test/resources/workflows-samples/for-sum-fixed.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
document:
dsl: '1.0.0-alpha5'
namespace: test
name: for-sum-fixed-example
version: '0.1.0'
do:
- sumAll:
for:
each: number
in:
- 1
- 2
- 3
do:
- accumulate:
set:
counter: ${.counter+$number}
export:
as: if .incr==null then {incr:[$number+1]} else .incr+=[$number+1] end
output:
as: .counter

3 changes: 1 addition & 2 deletions types/src/main/resources/schema/workflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,9 +711,8 @@ $defs:
description: A runtime expression used to get the collection to enumerate.
- type: array
title: ForInInlineArray
description: An inline array of objects to enumerate.
description: An inline array to enumerate.
items:
type: object
description: An item in the inline collection.
at:
type: string
Expand Down
Loading