Skip to content

Pin openDAQ ref#9

Merged
alexadereyko merged 7 commits intomainfrom
jira/TBBAS-3122-target-based-enforcement-ref
Mar 24, 2026
Merged

Pin openDAQ ref#9
alexadereyko merged 7 commits intomainfrom
jira/TBBAS-3122-target-based-enforcement-ref

Conversation

@alexadereyko
Copy link
Copy Markdown
Contributor

@alexadereyko alexadereyko commented Mar 20, 2026

  • Pin opendaq_ref to a specific commit with target-based CMake enforcement
  • Wrap external dependencies in ANCIENT CMake mode to allow legacy functions (e.g. include_directories() in GTest)
  • Disable force-fetching of dependencies when openDAQ is pre-installed via find_package, preventing FetchContent alias conflicts (e.g. fmt::fmt already exists)
  • Work around openDAQ's INSTALL_INTERFACE:fmt::fmt-header-only propagating FMT_HEADER_ONLY=1, which conflicts with compiled fmt::fmt used by spdlog (LNK2005 on MSVC)
  • Fix DLL path in CI: use bin/ instead of lib/ for Windows install-build-and-test job

@alexadereyko alexadereyko self-assigned this Mar 20, 2026
@alexadereyko alexadereyko force-pushed the jira/TBBAS-3122-target-based-enforcement-ref branch from 1092148 to 64d3ac8 Compare March 24, 2026 07:24
Copy link
Copy Markdown
Collaborator

@NikolaiShipilov NikolaiShipilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexadereyko alexadereyko force-pushed the jira/TBBAS-3122-target-based-enforcement-ref branch from d272c67 to 44f6965 Compare March 24, 2026 13:15
Co-authored-by: NikolaiShipilov <127689162+NikolaiShipilov@users.noreply.github.com>
@alexadereyko alexadereyko merged commit 744231b into main Mar 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants