Merged
Conversation
added 5 commits
March 16, 2026 14:27
added 5 commits
March 19, 2026 10:39
… if there is no write permission (only for a device)
0efcc13 to
73a991d
Compare
…d setOperationModeRecursive methods
Contributor
denise-opendaq
left a comment
There was a problem hiding this comment.
looks good to me. just need small changes :)
shared/libraries/opcuatms/opcuatms_client/src/objects/tms_client_function_impl.cpp
Outdated
Show resolved
Hide resolved
shared/libraries/opcuatms/opcuatms_client/src/objects/tms_client_function_impl.cpp
Outdated
Show resolved
Hide resolved
shared/libraries/opcuatms/opcuatms_client/src/objects/tms_client_object_impl.cpp
Outdated
Show resolved
Hide resolved
shared/libraries/opcuatms/opcuatms_client/src/objects/tms_client_object_impl.cpp
Outdated
Show resolved
Hide resolved
shared/libraries/opcuatms/opcuatms_client/src/objects/tms_client_procedure_impl.cpp
Outdated
Show resolved
Hide resolved
shared/libraries/opcuatms/tests/opcuatms_integration/test_tms_user_access.cpp
Outdated
Show resolved
Hide resolved
shared/libraries/opcuatms/tests/opcuatms_integration/test_tms_user_access.cpp
Outdated
Show resolved
Hide resolved
shared/libraries/opcuatms/tests/opcuatms_integration/test_tms_user_access.cpp
Outdated
Show resolved
Hide resolved
shared/libraries/opcuatms/tests/opcuatms_integration/test_tms_user_access.cpp
Outdated
Show resolved
Hide resolved
shared/libraries/opcuatms/tests/opcuatms_integration/test_tms_user_access.cpp
Outdated
Show resolved
Hide resolved
JakaMohorko
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief:
This pull request introduces changes to the client-side of the OPC UA module in accordance with the Authentication Modelling Guide. When a user does not have sufficient permissions to read, write, or execute, the corresponding properties and attributes of openDAQ entities are set accordingly. Additionally, the behavior of certain methods is adjusted based on the user’s permissions.
Description
FunctionandProcedurecalls return proper error code on client side if user access denied;readOnlyflag for properties on client side if there is no write permission;BeginUpdateandEndUpdatemethods return proper error code on client side;attributeslocking on client side if there is no write access;getAvailableFunctionBlockTypesmethod returns an empty list on client side if there is no write permission (only for adevice);setOperationModeandsetOperationModeRecursivemethods return proper error code on client side;acceptsSignalmethod returnsfalseon client side if there is no write permission;Known issues
getAvailableFunctionBlockTypesmethod has not been implemented forFunctionBlock;getAvailableDeviceTypesandgetAvailableDevicesmethods have not been implemented forDevice;lockand 'unlock' methods have not been implemented forDevice;