Conversation
WalkthroughVersion bump to openinula 1.0.1 across packages. Updated peer/dev dependency ranges in inula-intl and inula-router. Bumped versions for inula and its scripts package. Added a 1.0.1 changelog entry noting “fix: export Action type.” Removed a redundant changeset entry. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
packages/inula/package.json (1)
7-7: Version bump looks good; consider updating Node engine floor in a follow-up.Approved. As a minor housekeeping follow-up (not blocking),
"engines.node": ">=0.10.0"is unrealistically low for modern toolchains; consider raising to something like ">=14" or ">=16" to avoid accidental installs on unsupported runtimes.packages/inula-router/package.json (1)
28-28: Deps aligned to 1.0.1; tighten peer range to avoid future-major breakage.Approved. To prevent accidental compatibility claims for 2.x, consider constraining peer range to the current major.
Apply if desired:
"devDependencies": { - "openinula": "^1.0.1", + "openinula": "^1.0.1", ... "peerDependencies": { - "openinula": ">=1.0.1" + "openinula": ">=1.0.1 <2" },Also applies to: 39-39
packages/inula/CHANGELOG.md (1)
3-8: Changelog entry is clear and scoped.Looks good. Optional: include a brief note or link on what “export Action type” unblocks for consumers (e.g., TS import path), to aid release notes readers.
packages/inula-intl/package.json (1)
27-27: Peer/dev dependency bumps aligned; consider semver-safe peer constraint.Approved. Similar to router, you may want to cap peers to the 1.x line.
Optional change:
"peerDependencies": { - "openinula": ">=1.0.1" + "openinula": ">=1.0.1 <2" }, "devDependencies": { - "openinula": "^1.0.1", + "openinula": "^1.0.1",Also applies to: 31-31
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (6)
.changeset/twelve-cobras-tie.md(0 hunks)packages/inula-intl/package.json(1 hunks)packages/inula-router/package.json(2 hunks)packages/inula/CHANGELOG.md(1 hunks)packages/inula/package.json(1 hunks)packages/inula/scripts/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/twelve-cobras-tie.md
🔇 Additional comments (1)
packages/inula/scripts/package.json (1)
7-7: Template package.json version aligned; verify publish pipeline uses this template.Approved. Please confirm CI/build copies this file into
packages/inula/build/inula/package.jsonbeforenpm publish(sincepublishConfig.directorypoints there), and that the"exports"/"types"fields match the built layout.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.
Releases
openinula@1.0.1
Patch Changes
Summary by CodeRabbit
Bug Fixes
Chores
Documentation