chore(build-logic): add missing dependencies to version catalog & missing build logic files #2572

amanna13 · 2026-01-12T20:55:32Z

Fixes - Jira-#598

chore(build-logic): complete version catalogue and build logic setup

buid.mp4

Add missing dependencies to version catalogue
Finalize build logic configuration
Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything
If you have multiple commits please combine them into one commit by squashing them.

coderabbitai · 2026-01-12T20:55:38Z

Important

Review skipped

Too many files!

This PR contains 179 files, which is 79 over the limit of 100.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🔍 Trigger a full review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

- Add missing dependencies to version catalogue - Finalize build logic configuration

itsPronay · 2026-01-16T16:18:58Z

build-logic/convention/build.gradle.kts

        }
        register("androidFirebase") {
-            id = "mifos.android.application.firebase"
+            id = "org.convention.android.application.firebase"


why are we changing this

I have followed how the KMP template sync was done in mifos-mobile and mobile-wallet. Those have this changes
Please have a look into this similar PRs
https://github.com/openMF/mifos-mobile/pull/2967/files
https://github.com/openMF/mobile-wallet/pull/1894/files

@amanna13 using 2 different types of id will only create confusion, if you are replacing mifos with org.convention you should do it in the whole project or keep it as it is.

I guess that's a gradual replacement. This pr is intended to fix the build for the core-base which got merged recently.

@itsPronay I believe only project specific ones use mifos as a prefix and others use org.convention, which are common to all projects and can be used as it is from kmp-project-template.

@biplab1 I see, I got confused earlier

biplab1

Looks good to me. This can be merged.

biplab1 · 2026-01-22T15:25:29Z

@amanna13 Have you checked the build on your PR branch? Is the app building fine? Please upload a screen recording in the PR description.

amanna13 · 2026-01-22T15:55:43Z

@amanna13 Have you checked the build on your PR branch? Is the app building fine? Please upload a screen recording in the PR description.

@biplab1 Yes it's building fine, attaching a screen recording soon. The ony issue was, there was a build failure for the demoDebug variant of the client app. You can see that in this PR I have commented out the apply("org.convention.android.application.firebase") inside build-logic > convention > AndroidApplicationConventionPlugin to temporarily fix it.

The actual issue is in cmp-android/google-services.json, there’s no matching Firebase client entry for DemoDebug

biplab1 · 2026-01-23T16:29:08Z

@amanna13 Have you checked the build on your PR branch? Is the app building fine? Please upload a screen recording in the PR description.

@biplab1 Yes it's building fine, attaching a screen recording soon. The ony issue was, there was a build failure for the demoDebug variant of the client app. You can see that in this PR I have commented out the apply("org.convention.android.application.firebase") inside build-logic > convention > AndroidApplicationConventionPlugin to temporarily fix it.

The actual issue is in cmp-android/google-services.json, there’s no matching Firebase client entry for DemoDebug

@amanna13 I think we can handle this issue in a separate ticket. Please create a ticket to update google-services.json and handle this convention plugin error which results in a package name different from that listed in the google-services.json.

amanna13 · 2026-01-23T16:31:45Z

@biplab1 So it's commented out for now. so should i request for a merge ?!

niyajali · 2026-01-23T16:33:53Z

@amanna13 Have you checked the build on your PR branch? Is the app building fine? Please upload a screen recording in the PR description.

@biplab1 Yes it's building fine, attaching a screen recording soon. The ony issue was, there was a build failure for the demoDebug variant of the client app. You can see that in this PR I have commented out the apply("org.convention.android.application.firebase") inside build-logic > convention > AndroidApplicationConventionPlugin to temporarily fix it.

The actual issue is in cmp-android/google-services.json, there’s no matching Firebase client entry for DemoDebug

No, never do that instead copy the google services file from another project(https://github.com/openMF/kmp-project-template/blob/dev/cmp-android/google-services.json) and add these client info

    {
      "client_info": {
        "mobilesdk_app_id": "1:728434912738:android:53d0930e402622611a1dbb",
        "android_client_info": {
          "package_name": "com.mifos.mifosxdroid.demo.debug"
        }
      },
      "oauth_client": [
        {
          "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com",
          "client_type": 3
        }
      ],
      "api_key": [
        {
          "current_key": "AIzaSyCUz3P8uUExMFcPHa1Ga3DBKhjK5zxNn70"
        }
      ],
      "services": {
        "appinvite_service": {
          "other_platform_oauth_client": [
            {
              "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com",
              "client_type": 3
            }
          ]
        }
      }
    },
    {
      "client_info": {
        "mobilesdk_app_id": "1:728434912738:android:53d0930e402622611a1dbb",
        "android_client_info": {
          "package_name": "com.mifos.mifosxdroid.debug"
        }
      },
      "oauth_client": [
        {
          "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com",
          "client_type": 3
        }
      ],
      "api_key": [
        {
          "current_key": "AIzaSyCUz3P8uUExMFcPHa1Ga3DBKhjK5zxNn70"
        }
      ],
      "services": {
        "appinvite_service": {
          "other_platform_oauth_client": [
            {
              "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com",
              "client_type": 3
            }
          ]
        }
      }
    },

niyajali · 2026-01-23T16:41:46Z

And there are some recent changes in the template project, take a look into that and do the required changes accordingly

biplab1 · 2026-01-24T07:59:52Z

build-logic/convention/src/main/kotlin/AndroidApplicationFirebaseConventionPlugin.kt

+                    // enabled if a Firebase backend is available and configured in
+                    // google-services.json.
+                    configure<CrashlyticsExtension> {
+                        mappingFileUploadEnabled = false


This should be true, since Crashlytics is configured for all projects.

Suggested change

mappingFileUploadEnabled = false

mappingFileUploadEnabled = true

This isn't required for debug builds, improving build and compile times. For production release builds, it will be overridden through the AndroidManifest configuration

Regarding the Google Services client: we have 2 product flavors and 2 build types configured across all projects, creating 4 Android build variants, plus iOS and web apps. We haven't registered the debug builds in Firebase because there's a limit of 20 apps per free account. Registering unnecessary debug variants would consume our quota and prevent us from adding new apps when needed...

This should be true, since Crashlytics is configured for all projects.

@niyajali I referred the following files and a comment:

https://github.com/openMF/kmp-project-template/blob/dev/build-logic/convention/src/main/kotlin/AndroidApplicationFirebaseConventionPlugin.kt

https://github.com/openMF/mifos-mobile/blob/development/build-logic/convention/src/main/kotlin/AndroidApplicationFirebaseConventionPlugin.kt

https://github.com/openMF/mobile-wallet/blob/development/build-logic/convention/src/main/kotlin/AndroidApplicationFirebaseConventionPlugin.kt

https://mifos.slack.com/archives/C086SHY8ZPF/p1756520217688219?thread_ts=1756458555.957409&cid=C086SHY8ZPF

Then those need to be updated to improve the build and compile time for debug builds

Regarding the Google Services client: we have 2 product flavors and 2 build types configured across all projects, creating 4 Android build variants, plus iOS and web apps. We haven't registered the debug builds in Firebase because there's a limit of 20 apps per free account. Registering unnecessary debug variants would consume our quota and prevent us from adding new apps when needed...

@niyajali Can we not exclude the debug build variant from the relevant Gradle task instead of supplying placeholder values in google-services.json?

I think we're overcomplicating this. Why not just copy the existing client definition and change the package name? That's a 1-2 minute task that won't break anything. Updating internal Gradle configurations is risky, I've published multiple apps and know how unpredictable Gradle can be. Most issues only show up in release builds. So it's better to stick with the mentioned approach and sometimes we need the debug variants to test the functionality by using the created client Id..

amanna13 · 2026-01-25T11:22:52Z

Hey @niyajali, I tried with what you suggested with the google-services and it did work.

I'm keeping Crashlytics true, its currently set on true for mifos-mobile but it was false in android-client

And there are some recent changes in the template project, take a look into that and do the required changes accordingly

Let's keep it what we are currently doing for now, because of this PR the core-base haven't merged yet and a lot of other PR's are waiting for that.
Dependency updates and all can be addressed once this is merged in a seperate PR, because a lot of dependencies like "room" was upgraded which introduced stricter type validation, which is currently failing I checked.

biplab1 · 2026-01-26T14:43:52Z

@amanna13 I am curious - since you might have built using both the settings:

Does the compile and build times for debug variant build gets affected? Can you verify this:

Then those need to be updated to improve the build and compile time for debug builds

amanna13 · 2026-01-26T17:48:24Z

Does the compile and build times for debug variant build gets affected?

@biplab1 I verified the Debug build performance by running in the same environment. With mappingFileUpload enabled, the Debug build took ~5m 30s, compared to ~3m 52s when disabled, somewhat close to 30% improvement

biplab1 · 2026-01-27T14:15:00Z

Does the compile and build times for debug variant build gets affected?

@biplab1 I verified the Debug build performance by running in the same environment. With mappingFileUpload enabled, the Debug build took ~5m 30s, compared to ~3m 52s when disabled, somewhat close to 30% improvement

@amanna13 I am assuming you did a clean build before testing each of the settings.

Please keep the mappingFileUpload disabled for now in this project, other projects which have it enabled will also be disabled as recommended by @niyajali .

Can you also address this as pointed out by @niyajali:

And there are some recent changes in the template project, take a look into that and do the required changes accordingly

For dependencies, I think we can update them to a version where the changes in the project are minimal and manageable at the current moment.

amanna13 · 2026-01-27T14:21:54Z

I am assuming you did a clean build before testing each of the settings.

Yes I did clean build. Okay sure I will disable that.

For dependencies, I think we can update them to a version where the changes in the project are minimal and manageable at the current moment.

Yeah, that will work, it will take me one more day to do so. I was saying previously to merge this as it is, keeping in mind the priority of this task.

biplab1 · 2026-01-27T14:49:59Z

@amanna13 If you face any problems, feel free to start a Slack thread tagging @niyajali and me to expedite the work on this PR.

amanna13 force-pushed the chore/sync-version-catalogue-buildlogic branch 2 times, most recently from 0f2fe17 to b70a147 Compare January 16, 2026 14:03

amanna13 marked this pull request as ready for review January 16, 2026 14:06

amanna13 marked this pull request as draft January 16, 2026 14:16

chore(build-logic): complete version catalogue and build logic setup

6c41344

- Add missing dependencies to version catalogue - Finalize build logic configuration

amanna13 force-pushed the chore/sync-version-catalogue-buildlogic branch from b70a147 to 6c41344 Compare January 16, 2026 14:24

amanna13 marked this pull request as ready for review January 16, 2026 14:43

itsPronay reviewed Jan 16, 2026

View reviewed changes

itsPronay requested a review from HekmatullahAmin January 16, 2026 16:20

biplab1 approved these changes Jan 22, 2026

View reviewed changes

Merge branch 'development' into chore/sync-version-catalogue-buildlogic

1fa1417

biplab1 reviewed Jan 24, 2026

View reviewed changes

fix: addressed changes in google-services.json and crashlytics

8da4065

amanna13 requested review from biplab1 and niyajali January 26, 2026 10:24

amanna13 added 2 commits January 28, 2026 10:13

fix: Disabled crashlytics mapping file upload for faster builds

cfcc0cb

fix(workflows): correct sync directories workflow for scheduled runs

bc3795f

chore: updates and add support for ios language set support

b3ffce5

	mappingFileUploadEnabled = false
	mappingFileUploadEnabled = true

chore(build-logic): add missing dependencies to version catalog & missing build logic files #2572

Are you sure you want to change the base?

chore(build-logic): add missing dependencies to version catalog & missing build logic files #2572

Uh oh!

Conversation

amanna13 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

chore(build-logic): complete version catalogue and build logic setup

Uh oh!

coderabbitai bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

biplab1 left a comment

Choose a reason for hiding this comment

Uh oh!

biplab1 commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amanna13 commented Jan 22, 2026

Uh oh!

biplab1 commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amanna13 commented Jan 23, 2026

Uh oh!

niyajali commented Jan 23, 2026

Uh oh!

niyajali commented Jan 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

biplab1 Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amanna13 commented Jan 25, 2026

Uh oh!

biplab1 commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amanna13 commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

biplab1 commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amanna13 commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

biplab1 commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

amanna13 commented Jan 12, 2026 •

edited

Loading

coderabbitai bot commented Jan 12, 2026 •

edited

Loading

biplab1 commented Jan 22, 2026 •

edited

Loading

biplab1 commented Jan 23, 2026 •

edited

Loading

biplab1 Jan 25, 2026 •

edited

Loading

biplab1 commented Jan 26, 2026 •

edited

Loading

amanna13 commented Jan 26, 2026 •

edited

Loading

biplab1 commented Jan 27, 2026 •

edited

Loading

amanna13 commented Jan 27, 2026 •

edited

Loading

biplab1 commented Jan 27, 2026 •

edited

Loading