PHEE-379: add Account Mapper and G2P Config modules with functional create forms - #7
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds two new feature modules—Account Mapper and G2P Payment Config—and wires the existing route pages to render these new module UIs, including list views (mock-backed) and create forms with basic UX (success banner + tab switch).
Changes:
- Replaced placeholder pages with re-exports to newly added module entry components.
- Implemented mock-backed list tabs (tables + pagination) for Beneficiaries and G2P Payment Configs.
- Implemented create-form tabs for both modules, including success banners and tab navigation behavior.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/G2PConfig.tsx | Re-exports the new G2P Config module page component. |
| src/pages/AccountMapper.tsx | Re-exports the new Account Mapper module page component. |
| src/modules/g2p-config/types.ts | Adds the typed G2PConfig model. |
| src/modules/g2p-config/mocks/g2pConfigs.mock.ts | Adds typed mock data for the G2P list tab. |
| src/modules/g2p-config/G2PPaymentTab.tsx | Implements the G2P list tab table, status filtering, and pagination. |
| src/modules/g2p-config/G2PConfig.tsx | Implements the G2P module wrapper (breadcrumb + tabs). |
| src/modules/g2p-config/CreateG2PTab.tsx | Implements the G2P create form and success UX. |
| src/modules/account-mapper/types.ts | Adds the typed Beneficiary model. |
| src/modules/account-mapper/mocks/beneficiaries.mock.ts | Adds typed mock data for the Beneficiaries list tab. |
| src/modules/account-mapper/CreateBeneficiariesTab.tsx | Implements the Beneficiaries create form and success UX. |
| src/modules/account-mapper/BeneficiariesTab.tsx | Implements the Beneficiaries list tab table and pagination. |
| src/modules/account-mapper/AccountMapper.tsx | Implements the Account Mapper module wrapper (breadcrumb + tabs). |
| src/components/ui/label.tsx | Adds a shared Label UI component. |
| src/components/ui/input.tsx | Adds a shared Input UI component. |
| src/components/shared/StatusBadge.tsx | Extends StatusBadge styling/props to support G2P-specific inactive rendering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
All Copilot suggestions addressed and pushed:
|
DavidH-1
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
Epic: PHEE-363
Closes: PHEE-378
Summary
Builds the Account Mapper and G2P Payment Config module pages with
typed mock data and functional create forms.
Changes
Account Mapper
AccountMapper.tsxwith breadcrumb and 2 tabs (Beneficiaries, Create Beneficiaries)BeneficiariesTab.tsxwith filter chips, DataTable and paginationCreateBeneficiariesTab.tsxwith 6-field form (Full Name, Government Entity, Financial Institution, Functional ID, Financial Address, Payment Modality)beneficiaries.mock.tsG2P Payment Config
G2PConfig.tsxwith breadcrumb and 2 tabs (G2P Payment, Create)G2PPaymentTab.tsxwith filter chips, DataTable and paginationCreateG2PTab.tsxwith 5-field form (Government Entity, Program, Payer DFSP, Payment Account, Status)g2pConfigs.mock.tsScreenshots