PHEE-380: add Login page and Settings page with accordion sections - #8
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces the actual implementations for the Login and Settings pages (moving them into src/modules/...), and wires the src/pages/... routes to re-export those module components. It also adds new Radix-based UI primitives (Accordion, Checkbox, Switch) used by these pages.
Changes:
- Replace placeholder
LoginPageandSettingspages with module-backed implementations. - Add a new Settings UI with multiple accordion sections and “saved” feedback banners.
- Add
Accordion,Checkbox, andSwitchUI components to support the new screens.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/Settings.tsx | Switches the route page to re-export the new module Settings implementation. |
| src/pages/LoginPage.tsx | Switches the route page to re-export the new module Login implementation. |
| src/modules/settings/Settings.tsx | Implements the Settings screen with accordion sections, inputs, and save feedback. |
| src/modules/auth/Login.tsx | Implements the Login screen UI and temporary navigation logic. |
| src/components/ui/switch.tsx | Adds a Switch UI primitive used for Dark Mode toggle. |
| src/components/ui/checkbox.tsx | Adds a Checkbox UI primitive used for Remember Me. |
| src/components/ui/accordion.tsx | Adds an Accordion UI primitive used to structure Settings sections. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
Epic: PHEE-363
Closes: PHEE-380
Summary
Adds the Login page and Settings page to complete the core UI modules.
Changes
Login Page
/(Keycloak integration coming in next PR)Settings Page
Screenshots