[codex] Show security scans in the Codex app - #471
Conversation
mldangelo-oai
left a comment
There was a problem hiding this comment.
Non-blocking QA notes on eb941990. The shared-database approach worked with the desktop's database-only task list. I could read and continue the saved scan task. I'd keep scan execution in its isolated home.
The name was the remaining issue I reproduced; details are inline. It would also be useful to share the small app-server client with #477 instead of maintaining two request loops.
The full local suite passed 1,139 tests with 11 skipped. The branch currently conflicts with main, and the title and Windows checks still fail. A branch refresh, Conventional Commit title, and Windows rerun would help. The observed Windows failure occurs during credential-home setup, so I wouldn't attribute it to this feature without a clean rerun.
| await request(2, "thread/name/set", { | ||
| threadId, | ||
| name: options.title, | ||
| }); |
There was a problem hiding this comment.
Non-blocking: the task is visible and resumable, but naming it through the private-home app server did not make the name appear in the app-home database-only list with the pinned runtime. Naming the same task from the app-home side did. Could we use the supported shared-metadata path, or do this metadata-only operation from the app-home side, while leaving scan execution and credentials isolated? I'd check the name from the app's listing context in the regression test.
Summary
Security scans use a private Codex home, so the Codex app cannot see their tasks. Show each scan in the app without moving its credentials or session files.
Changes
Testing
bun test --timeout 30000 tests-ts/api.test.ts tests-ts/api-attribution-concurrency.test.ts tests-ts/desktop-session.test.ts— 122 passed.pnpm run typespnpm run formatpnpm run buildpnpm run check:package /private/tmp/openai-codex-security-0.1.12.tgzRisk and rollout
Scan authentication, private session storage, and repository path checks do not change. If app task setup fails, scanning falls back to the existing behavior.
Public disclosure review