Skip to content

fix(workbench): keep repository inventory and snapshots within the target - #472

Draft
mldangelo-oai wants to merge 15 commits into
mainfrom
mdangelo/codex/confine-repository-parent-symlinks-20260815
Draft

fix(workbench): keep repository inventory and snapshots within the target#472
mldangelo-oai wants to merge 15 commits into
mainfrom
mdangelo/codex/confine-repository-parent-symlinks-20260815

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

Keep generated repository inventories and Git snapshots inside the selected repository target.

Changes

  • Share the canonical-directory containment check across diff inventory, ranking previews, and Git snapshots.
  • Keep committed revision history and deleted inventory rows available, reject unsafe changed-file inventories, and retain empty-preview ranking rows where appropriate.
  • Preserve selected nested roots, internal Windows junctions, equivalent filesystem spellings, vanished staged paths, and nonblocking progress estimates.
  • Use one snapshot rejection path and retain distinct alias-aware parent and final-leaf checks before ranking previews. Keep the existing synthetic path and snapshot regression coverage.

Testing

  • bun test --timeout 30000 tests-ts/workbench-canonical-paths.test.ts tests-ts/diff-rank-input.test.ts tests-ts/compact-diff-scan.test.ts — 11 passed, 2 expected platform skips, 0 failed.
  • pnpm run types — passed.
  • pnpm run format — passed.
  • Python syntax compilation of the changed ranking module — passed.
  • git diff --check — passed.
  • bun test --timeout 30000 --randomize --seed 12345 ./tests-ts with JUnit reporting — Bun 1.3.14; 1,294 passed, 11 skipped, 0 failed, and 9,150 assertions. Live integration was disabled. The source head and tree stayed unchanged.
  • Native prepublish review — three fresh passes and independent verification, with no remaining findings.
  • Package inclusion and entrypoints are unchanged; fresh pushed-head package and cross-platform CI remain required.

Risk and rollout

Ordinary files, selected target roots, deleted history, existing missing-file handling, and supported diff modes retain their behavior. Both bundled-plugin version declarations are 0.1.21 in this standalone branch. If another plugin-changing PR lands first, refresh against main and increment both declarations together to the next unused version so already-staged plugins refresh correctly. Fresh pushed-head CI remains required.

Public disclosure review

Newly authored material was reviewed for public disclosure. Existing automated review comments contain access-restricted report references; maintainer cleanup remains outstanding.

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Aug 16, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 995da43fbf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 995da43fbf

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@mldangelo-oai
mldangelo-oai marked this pull request as ready for review August 16, 2026 02:41
@mldangelo-oai
mldangelo-oai marked this pull request as draft August 16, 2026 03:54

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current head, 648c15254b1bfc371fa75c17b0e02c5586307d6a.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 648c15254b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 648c15254b

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant