app-server: improve thread resume rejoin flow#11776
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c3fd0bb884
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
maxj-oai
force-pushed
the
maxj/thread-resume-rejoin-v2
branch
from
76fa1a5 to
1d81500
Compare
owenlin0
left a comment
owenlin0
left a comment
There was a problem hiding this comment.
small comments but hopefully @celia-oai can take a closer look
…join-v2 # Conflicts: # codex-rs/app-server/src/bespoke_event_handling.rs # codex-rs/app-server/src/codex_message_processor.rs
| } | ||
| } | ||
| let shutdown_when_no_connections = matches!(transport, AppServerTransport::Stdio); | ||
| let single_client_mode = matches!(transport, AppServerTransport::Stdio); |
There was a problem hiding this comment.
I wonder if this should be a feature flag, something like single_client_mode = matches!(transport, AppServerTransport::Stdio) or single_client_mode_feature_flag_on
There was a problem hiding this comment.
I don't think so; this is already user-controlled via the --listen cli argument - using stdio:// (the default) necessarily implies single-client mode (and shut down when no connections) vs a connection-oriented transport which supports multiple clients and should survive disconnect
…join-v2 # Conflicts: # codex-rs/app-server-protocol/src/protocol/thread_history.rs
3 participants
thread/resume response includes latest turn with all items, in band so no events are stale or lost
Testing