app server request/response structure for sandbox nux#11792
app server request/response structure for sandbox nux#11792iceweasel-oai wants to merge 1 commit intomainfrom
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 96557c4854
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if WindowsSandboxLevel::from_config(&config) == WindowsSandboxLevel::Elevated { | ||
| self.outgoing | ||
| .send_response( | ||
| request_id, | ||
| WindowsSandboxNuxStartResponse { accepted: false }, | ||
| ) | ||
| .await; | ||
| return; | ||
| } | ||
|
|
||
| self.outgoing | ||
| .send_response( | ||
| request_id.clone(), | ||
| WindowsSandboxNuxStartResponse { accepted: true }, | ||
| ) | ||
| .await; |
There was a problem hiding this comment.
windows_sandbox_nux_start only rejects when sandbox mode is already elevated, then starts the elevated NUX flow unconditionally. It never checks ELEVATED_SANDBOX_NUX_ENABLED (documented as a global kill switch in core/src/windows_sandbox.rs). If that switch is set false for emergency rollback, app-server still runs the new flow instead of reverting behavior.
Useful? React with 👍 / 👎.
| tokio::spawn(async move { | ||
| let mut host = AppServerWindowsSandboxNuxHost { | ||
| outgoing, | ||
| surface: protocol_surface, | ||
| }; | ||
| let outcome = | ||
| codex_core::windows_sandbox_nux::run_windows_sandbox_nux(&mut host, run_params) | ||
| .await; |
There was a problem hiding this comment.
Each windowsSandbox/nuxStart call spawns a detached NUX task with no in-flight guard or deduplication. Repeated requests can run multiple prompt/setup loops concurrently on the same connection, interleave windowsSandbox/nuxPrompt requests, and race config persistence. This can lead to inconsistent user actions and setup state.
Useful? React with 👍 / 👎.
1 participant
No description provided.