tui: split remaining composer draft and footer state#22656
Open
etraut-openai wants to merge 2 commits into
Open
tui: split remaining composer draft and footer state#22656etraut-openai wants to merge 2 commits into
etraut-openai wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#22581 started separating the chat composer’s responsibilities, but
ChatComposerstill owned the remaining editable draft state alongside footer/status presentation state. This follow-up makes those ownership lines explicit so future composer changes have a smaller blast radius andBottomPanedoes not need to keep exposing scattered draft getters.This is just a refactor. No functional or behavioral changes are intended.
What changed
bottom_pane/chat_composer/draft_state.rs.bottom_pane/chat_composer/footer_state.rs.ComposerDraftSnapshotfor restore flows, replacing several ad hocBottomPanepass-through reads.Verification
RUST_MIN_STACK=8388608 cargo test -p codex-tuicargo insta pending-snapshots