[sa-server][tui] keep skills available when workspace plugins are disabled, extend to TUI#22658
Open
zamoshchin-openai wants to merge 2 commits into
Open
[sa-server][tui] keep skills available when workspace plugins are disabled, extend to TUI#22658zamoshchin-openai wants to merge 2 commits into
zamoshchin-openai wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills/listwhen workspace plugin UI is disabled.Why
Workspace-level plugin disabling is meant to hide plugin UI in Codex, not remove Skills from the product surface. The previous app-server filtering path dropped plugin-backed skill roots entirely, which made the Skills fallback disappear as well.
TUI bootstrap detail
codex-rs/tui/src/app.rsapplies the effective plugin visibility returned by app-server bootstrap back into the local TUI config. If the server says plugins are disabled for the workspace, the TUI disablesFeature::Pluginslocally so later TUI behavior follows the server-side policy while Skills remain available. If that local feature update fails, the TUI logs a warning and continues startup instead of turning the bootstrap path into a hard failure.Validation
cargo test -p codex-app-server --test all skills_list_keeps_plugin_skills_when_workspace_codex_plugins_disabledcargo test -p codex-tui plugins_enabled_from_feature_list