Remove SSE fixture loaders#22684
Open
pakrym-oai wants to merge 1 commit into
Open
Conversation
sayan-oai
approved these changes
May 14, 2026
sayan-oai
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Responses API test support already has structured SSE event builders. Keeping separate JSON fixture loaders made small mock streams harder to read and left an on-disk fixture for a single event.
What changed
load_sse_fixtureandload_sse_fixture_with_id_from_strfromcore_test_support.tests/fixtures/incomplete_sse.jsonResponses API fixture.responses::sse(...)and existing event helpers.Validation
cargo test -p codex-core --test all stream_no_completed::retries_on_early_closecargo test -p codex-core --test all history_dedupes_streamed_and_final_messages_across_turnscargo test -p codex-core --test all review::