Skip to content

Fix Windows sandbox clippy clones#22687

Merged
starr-openai merged 1 commit into
mainfrom
starr/main-rust-ci-full-windows-clippy-20260514
May 14, 2026
Merged

Fix Windows sandbox clippy clones#22687
starr-openai merged 1 commit into
mainfrom
starr/main-rust-ci-full-windows-clippy-20260514

Conversation

@starr-openai
Copy link
Copy Markdown
Contributor

Summary

  • remove two redundant PathBuf clones in Windows sandbox setup tests
  • fix current rust-ci-full Windows clippy failures on main

Validation

  • just fmt
  • attempted on dev: cargo clippy --target x86_64-pc-windows-msvc --tests --profile dev --timings -- -D warnings
    • blocked by missing MSVC cross toolchain on the Linux devbox (lib.exe / MSVC C toolchain unavailable)
  • live failure evidence: main rust-ci-full runs 25880209898 and 25879137967 failed on windows-sandbox-rs/src/bin/setup_main/win.rs with clippy::redundant_clone at the two edited callsites

@starr-openai starr-openai force-pushed the starr/main-rust-ci-full-windows-clippy-20260514 branch from 2489e68 to 9fde7cb Compare May 14, 2026 21:23
@starr-openai starr-openai force-pushed the starr/main-rust-ci-full-windows-clippy-20260514 branch from 9fde7cb to 80a1ecc Compare May 14, 2026 21:59
@starr-openai starr-openai marked this pull request as ready for review May 14, 2026 22:54
@starr-openai starr-openai merged commit 7c11c14 into main May 14, 2026
50 of 56 checks passed
@starr-openai starr-openai deleted the starr/main-rust-ci-full-windows-clippy-20260514 branch May 14, 2026 22:54
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants