TUI: split history cells into focused modules#22704
Open
etraut-openai wants to merge 2 commits into
Open
Conversation
canvrno-oai
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
codex-rs/tui/src/history_cell.rshad become the dumping ground for transcript rendering: the shared trait, common helpers, and the concrete cells for messages, plans, MCP/search, notices, patches, approvals, session chrome, and separators all lived together. That made small transcript changes require reopening a very large file and made ownership less obvious.What changed
history_cell.rswith ahistory_cell/module tree organized by concern.crate::history_cell::*surface stable through re-exports inhistory_cell/mod.rs.history_cell/tests.rs.Reviewer notes
codex-rs/tui/src/history_cell/snapshots/moved with the extracted test module.instaresolves these unnamed snapshots relative to the source file that declares them, so this is path churn only; snapshot contents were not updated.