Prevent Esc from dismissing or rewinding /side#22710
Merged
Merged
Conversation
/side
/side/side
8a64815 to
0bad551
Compare
/side/side
0bad551 to
4c65f47
Compare
apanasenko-oai
approved these changes
May 14, 2026
canvrno-oai
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #22599
Why
/sidecurrently letsEscreturn to the parent thread. Multiple users reported that this collides with queued-steer UI that also advertisesEsc, so a timing-sensitive keypress can dismiss an ephemeral side chat instead of sending the queued prompt.After removing that dismissal shortcut, the same
Escpath could fall through to main-thread backtrack/edit-previous handling, which is not valid for ephemeral side conversations. This keeps/sideout of both globalEscbehaviors.What changed
Escfrom the/sidereturn shortcut matcher while keeping the existingCtrl+CandCtrl+Dbehavior.Ctrl+Cas the return shortcut.Esckeymap label to describe backtracking only.Editing previous prompts is unavailable in side conversations.when that path would have fired.Escbehavior, such as Vim insert-mode escape, routed locally.Verification
Manually tested
/sideuse cases andEsc,Ctrl+C,Ctrl+D.