Measure MCP UI URIs missing trusted connector IDs#31320
Open
martinauyeung-oai wants to merge 2 commits into
Open
Measure MCP UI URIs missing trusted connector IDs#31320martinauyeung-oai wants to merge 2 commits into
martinauyeung-oai wants to merge 2 commits into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
martinauyeung-oai
force-pushed
the
martinauyeung/measure-mcp-uri-without-connector
branch
from
f24f283 to
35d7a8b
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35d7a8bb99
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
martinauyeung-oai
force-pushed
the
martinauyeung/measure-mcp-uri-without-connector
branch
from
35d7a8b to
5cbd5b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex.mcp.ui_resource_uri_without_trusted_connector_idwhen a tool has a non-empty UI resource URI but no non-empty trusted connector ID.server_kindvalues to distinguish Codex Apps, selected plugins, and other MCP servers.Why
This measures whether the top-level
mcpAppResourceUrican be removed safely in favor ofappContext.resourceUri.Validation
cargo fmt --checkgit diff --checkcodex-coretest was not completed because the local volume ran out of space while compiling dependencies.