Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1c44cd34e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anp-oai
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Codex-owned HTTP construction currently lives in
codex-clientalongside higher-level retry, SSE, and request-telemetry policy. That makes it difficult to apply shared network behavior consistently across crates, particularly system proxy/PAC resolution, custom CA handling, and the ChatGPT Cloudflare cookie policy. It also leaves no clear crate boundary for migrating directreqwestusage behind a single Codex abstraction.This change establishes that low-level ownership boundary without changing request behavior. It builds on the system proxy support introduced in #26706, #26707, #26708, and #26709.
What changed
codex-rs/http-clientas thecodex-http-clientcrate.reqwesttransport, custom CA handling, Cloudflare cookie policy, and macOS/Windows proxy resolution into the new crate.codex-client.codex-client, including compatibility aliases forCodexHttpClientandCodexRequestBuilder, so existing consumers do not change in this PR.Scope boundary
This PR deliberately stops at the crate extraction. Stacked follow-up #31331 migrates downstream imports from
codex-clienttocodex-http-client, keeping this change focused on ownership and compatibility rather than mixing in repository-wide call-site churn.Review guide
GitHub reports 30 changed files, of which 17 are detected renames. A useful review order is:
codex-rs/http-client/Cargo.tomlandcodex-rs/http-client/src/lib.rs.codex-rs/codex-client/Cargo.tomlandcodex-rs/codex-client/src/lib.rsfor what remains in the higher-level crate and how compatibility is preserved.HttpClientandRequestBuilder.codex-rs/Cargo.toml,codex-rs/Cargo.lock, and the twoBUILD.bazelfiles as mechanical workspace integration.Test plan
just test -p codex-http-client -p codex-client(38 tests)codex-api,codex-backend-client,codex-cloud-tasks,codex-exec-server,codex-login, andcodex-model-providerconsumers against the compatibility re-exports.Stack created with Sapling. Best reviewed with ReviewStack.