[codex] Align skill creator paths with supported locations#31334
Open
alexsong-oai wants to merge 1 commit into
Open
[codex] Align skill creator paths with supported locations#31334alexsong-oai wants to merge 1 commit into
alexsong-oai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skill-creatorinstructions..agents/skills, user skills to$HOME/.agents/skills, and admin skills to/etc/codex/skills.init_skill.pyhelp/examples to match the documented paths and make its sibling helper import stable when invoked by path.Root Cause
The bundled
skill-creatordid not clearly map skill scope to the supported authoring paths. Its examples used genericskills/...paths, which could lead Codex to create validSKILL.mdfiles in locations that are not the documented repo/user authoring roots.Fixes #14941.
Validation
python3 codex-rs/skills/src/assets/samples/skill-creator/scripts/quick_validate.py codex-rs/skills/src/assets/samples/skill-creatorpython3 codex-rs/skills/src/assets/samples/skill-creator/scripts/init_skill.py --helpjust fmtjust test -p codex-skillsgit diff --checkjust execin a temporary git repo with$skill-creator; verified it created.agents/skills/e2e-skill-path-check/SKILL.mdand the bundledquick_validate.pyaccepted the generated skill.