core: make thread activity lifecycle atomic#31338
Conversation
winston-openai
force-pushed
the
dev/winston/thread-idle-shutdown-reservations
branch
from
87933ce to
c1de464
Compare
winston-openai
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1de464dcb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
winston-openai
force-pushed
the
dev/winston/thread-idle-shutdown-reservations
branch
from
c1de464 to
b133fd4
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b133fd4368
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
1 participant
Summary
Stack
Test plan
just test -p codex-core 'thread_activity::tests' 'cancelled_submission_and_idle_shutdown_release_lifecycle_reservations' 'failed_idle_shutdown_delivery_stays_closed' 'failed_explicit_shutdown_delivery_stays_closed'CARGO_INCREMENTAL=0 just fix -p codex-corejust fmt