TUI: prefer CODEX_HOME for IDE IPC#31347
Open
etraut-openai wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The IDE extension is moving its Unix IPC socket from
/tmp/codex-ipc/ipc-<uid>.sockto$CODEX_HOME/ipc/ipc.sockto avoid ownership collisions on multi-user hosts. The TUI must discover the new socket without breaking compatibility with older extension versions.What changed
$CODEX_HOME/ipc/ipc.sockfirst, resolving$CODEX_HOMEthrough the existing helper.Manual validation
CODEX_HOME. After selecting a file containingCODEX_IPC_E2E_PRIMARY_PATH_MARKERand enabling/ide, the TUI returned that exact marker through$CODEX_HOME/ipc/ipc.sock. The extension-created IPC directory and socket had modes0700and0600.CODEX_HOMEthat had no primary socket and a controlled legacy<tmp>/codex-ipc/ipc-<uid>.sockproxy. The TUI returned the same exact marker, confirming the legacy fallback path works with the updated extension.Fixes #22966.