Skip to content

refactor(skills): share plugin namespace resolver#31358

Merged
anp-oai merged 1 commit into
codex/skill-namespace-root-probesfrom
codex/skill-namespace-resolver-dedupe
Jul 7, 2026
Merged

refactor(skills): share plugin namespace resolver#31358
anp-oai merged 1 commit into
codex/skill-namespace-root-probesfrom
codex/skill-namespace-resolver-dedupe

Conversation

@anp-oai

@anp-oai anp-oai commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

why

#31348 centralizes root-level plugin namespace resolution for ordinary skill loading, but the environment loader still carried a parallel namespace map, probe fanout, and ancestor-selection loop. Keeping both implementations would make namespace precedence fixes easy to apply in only one path.

what

  • reuse SkillNamespaceResolver from the environment loader
  • retain the environment loader's filter that avoids probing plugin roots without discovered skills
  • keep namespace resolution concurrent with skill file reads
  • delete the duplicate namespace map construction and per-skill ancestor walk

validation

  • just test -p codex-core-skills namespace (10 passed)

@anp-oai anp-oai merged commit 6b1ceea into codex/skill-namespace-root-probes Jul 7, 2026
30 of 32 checks passed
@anp-oai anp-oai deleted the codex/skill-namespace-resolver-dedupe branch July 7, 2026 04:41
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant