app-server: serialize teardown admission by thread id#31399
Closed
winston-openai wants to merge 1 commit into
Closed
app-server: serialize teardown admission by thread id#31399winston-openai wants to merge 1 commit into
winston-openai wants to merge 1 commit into
Conversation
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Serialize listener and teardown admission by the stable logical
ThreadId. Listener attachment andthread/resumenow acquire the global thread-list permit, subscribe to any existing exact teardown owner, drop the permit before waiting, and retry internally after completion instead of returning a normal "closing; retry" error.Running resume still reserves its connection before releasing admission. Unsubscribe and stale-connection cleanup register exact tracked claims before dropping the permit, so cancellation of a waiter cannot abandon cleanup. Realtime admission returns the exact
Arc<CodexThread>fetched and subscribed after any wait, preventing downstream operations from using a stale pre-wait generation.Archive and delete remain unchanged here because they operate on complete thread trees; their ownership moves with the atomic multi-ID subtree claim in the next stacked layer.
Stacked on #31395.
Validation