fix: export ApplyPatchTool and CustomTool approval callback types from top-level package#3491
Closed
rmotgi1227 wants to merge 1 commit into
Closed
fix: export ApplyPatchTool and CustomTool approval callback types from top-level package#3491rmotgi1227 wants to merge 1 commit into
rmotgi1227 wants to merge 1 commit into
Conversation
…rToolSafetyCheckData
Member
|
hmm, we'd like to hold off adding these as they are not commonly used plus developers can still import from agents.tool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ApplyPatchToolandCustomTooleach accept anon_approvalcallback, andComputerToolaccepts anon_safety_checkcallback. The types needed to annotate those callbacks are not exported from the top-levelagentspackage:ApplyPatchOnApprovalFunction/ApplyPatchOnApprovalFunctionResultCustomToolOnApprovalFunction/CustomToolOnApprovalFunctionResultComputerToolSafetyCheckDataThe equivalent MCP types (
MCPToolApprovalFunction,MCPToolApprovalFunctionResult) are already exported. This extends that to the remaining tool types.Related to #3450 which exports the Shell equivalents.