fix: export CallModelInputFilter, CallModelData, ModelInputData, and RunOptions from top-level package#3492
Closed
rmotgi1227 wants to merge 1 commit into
Closed
Conversation
…RunOptions from top-level agents package
Member
|
@rmotgi1227 run_config is not a private module plus we don't intend to expose everything from top-level agents. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunConfig.call_model_input_filteraccepts aCallModelInputFiltercallable. To implement one, callers needCallModelDataandModelInputData. These types are defined inrun_config.py(and listed in its__all__), but they are not re-exported from the top-levelagentspackage.RunOptions(theTypedDictversion ofRunConfigaccepted byRunner.run/Runner.run_streamed) has the same gap.The
ToolOutputTrimmerextension already implementsCallModelInputFilterand is documented as a public API, so users need these types to write their own filters.The fix adds the four names to the
from .run import ...block and to__all__insrc/agents/__init__.py.